Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8041

Do not concatenate the destination to L_RETURN_TO to allow better translations

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.1.0-b1
    • Component/s: Language pack
    • Labels:

      Description

      Well, i need a chage in language variables and some files to make my translation better.
      This might benefit other languages too, but i do not know that for sure.

      In jumpbox.html:

      <!-- IF S_VIEWTOPIC -->
      	<p></p><p><a href="{U_VIEW_FORUM}" class="left-box {S_CONTENT_FLOW_BEGIN}" accesskey="r">{L_RETURN_TO} {FORUM_NAME}</a></p>
      <!-- ELSEIF S_VIEWFORUM -->
      	<p></p><p><a href="{U_INDEX}" class="left-box {S_CONTENT_FLOW_BEGIN}" accesskey="r">{L_RETURN_TO} {L_INDEX}</a></p>
      <!-- ELSEIF SEARCH_TOPIC -->
      	<p></p><p><a class="left-box {S_CONTENT_FLOW_BEGIN}" href="{U_SEARCH_TOPIC}" accesskey="r">{L_RETURN_TO}: {SEARCH_TOPIC}</a></p>
      <!-- ELSEIF S_SEARCH_ACTION -->
      	<p></p><p><a class="left-box {S_CONTENT_FLOW_BEGIN}" href="{U_SEARCH}" title="{L_SEARCH_ADV}" accesskey="r">{L_RETURN_TO_SEARCH_ADV}</a></p>
      <!-- ENDIF -->
      

      I need to combine "

      {L_RETURN_TO} and {FORUM_NAME}" to one variable because i need to insert text before and after {FORUM_NAME} to make it correct. (example, common.php / 'READING_TOPIC' where this is done)

      I need to combine "{L_RETURN_TO}

      and

      {L_INDEX}

      " to one variable because the inflection for finnish word for "Index"

      Combine

      {L_RETURN_TO}

      and

      {SEARCH_TOPIC}

      , same reason as the others.

      I can live with this, but it would be nice to have in 3.2 if it is not changed for 3.0.x
      It just looks a bit odd now...

        Activity

        Hide
        lurttinen Martti Lokka added a comment -

        Bah, forgot one.
        In common.php, 'INFORMATION' is used in few places.
        For example when you disable your board it displays 'INFORMATION' to users with an explanation why the board is closed.

        This same variable is used in viewtopic to direct moderators to MCP to view details about the topic.

        I can live with this too, but i would like to use something else in viewtopic. "view post details" or something like that in the tooltip.
        Maybe the 'POST_DETAILS' variable (in common.php) could be used as the next page title is the same.

        Not sure how that would affect other translations, if 'POST_DETAILS' is re used as tooltip.

        Show
        lurttinen Martti Lokka added a comment - Bah, forgot one. In common.php, 'INFORMATION' is used in few places. For example when you disable your board it displays 'INFORMATION' to users with an explanation why the board is closed. This same variable is used in viewtopic to direct moderators to MCP to view details about the topic. I can live with this too, but i would like to use something else in viewtopic. "view post details" or something like that in the tooltip. Maybe the 'POST_DETAILS' variable (in common.php) could be used as the next page title is the same. Not sure how that would affect other translations, if 'POST_DETAILS' is re used as tooltip.
        Hide
        lurttinen Martti Lokka added a comment -

        ucp_pm_header.html

        {L_RETURN_TO} {CUR_FOLDER_NAME}

        Need to combine these.

        Looks like this might affect every single variable where RETURN_TO is used.
        + we might have a problem everywhere where two language variables is used to form a sentence in english.

        /me goes to dig a little deeper...

        Show
        lurttinen Martti Lokka added a comment - ucp_pm_header.html {L_RETURN_TO} {CUR_FOLDER_NAME} Need to combine these. Looks like this might affect every single variable where RETURN_TO is used. + we might have a problem everywhere where two language variables is used to form a sentence in english. /me goes to dig a little deeper...
        Hide
        Acyd Burn Meik Sievertsen [X] (Inactive) added a comment -

        I am not sure... did i fix this? I remember i touched these areas a while back.

        Show
        Acyd Burn Meik Sievertsen [X] (Inactive) added a comment - I am not sure... did i fix this? I remember i touched these areas a while back.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            lurttinen Martti Lokka
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development