Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7995

Autoupdate misidentifies memberlist.php on re-check as not updated

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Trivial
    • Resolution: Cannot Reproduce
    • 3.0.4
    • None
    • Installation system
    • None
    • PHP Environment:
      Database:

    Description

      Re-checking files after autoupdating will keep flagging memberlist.php as NOT an updated file if you have the autoupdater use merge. The merged file will not be recognized as already updated.

      Also, every subsequent attempt to update the file via merge will keep adding this section again and again. At one point I had several of them next to each other.

            // If the user has m_approve permission or a_user permission, then list then display unapproved posts
            if ($auth->acl_getf_global('m_approve') || $auth->acl_get('a_user'))
            {
               $sql = 'SELECT COUNT(post_id) as posts_in_queue
                  FROM ' . POSTS_TABLE . '
                  WHERE poster_id = ' . $user_id . '
                     AND post_approved = 0';
               $result = $db->sql_query($sql);
               $member['posts_in_queue'] = (int) $db->sql_fetchfield('posts_in_queue');
               $db->sql_freeresult($result);
            }
            else
            {
               $member['posts_in_queue'] = 0;
            }

      I had this problem updating from 3.0.2 to 3.0.3 but there are reports that the problem is present in autoupadater from 3.0.3 to 3.0.4
      Topic: http://www.phpbb.com/community/viewtopic.php?f=46&t=1315475

      Attachments

        Activity

          People

            Acyd Burn Meik Sievertsen [X] (Inactive)
            phpDummie phpDummie [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: