Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7778

Increase limit of custom BBcodes

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.2
    • Fix Version/s: 3.0.9-RC1
    • Labels:
      None
    • Environment:
      PHP Environment: 5.2.6
      Database: MySQL 5.0.51a-community

      Description

      According the root/includes/acp/acp_bbcodes.php file the maximun value for a bbcode id is set to 1511 :
      Lines 207 to 210

      					if ($bbcode_id > 1511)
      					{
      						trigger_error($user->lang['TOO_MANY_BBCODES'] . adm_back_link($this->u_action), E_USER_WARNING);
      					}

      In the mysql_41_schema.sql for bbcodes, the row for bbcode_id is defined as

      bbcode_id tinyint(3) DEFAULT '0' NOT NULL,


      But according the documentation from mysql :

      TINYINT[(M)] [UNSIGNED] [ZEROFILL]

      A very small integer. The signed range is -128 to 127. The unsigned range is 0 to 255.

      source : http://dev.mysql.com/doc/refman/5.0/en/numeric-type-overview.html

      May be the row have to be INT or SMALLINT

      Like always, excuse me for my poor English, I speak Spanish.

        Issue Links

          Activity

          Hide
          leviatan21 leviatan21 [X] (Inactive) added a comment -

          Perhaps it should be asked at another place :
          It could change the column bbcode_id to MEDIUMINT and it does not affect the rest of the code?

          Thanks

          Show
          leviatan21 leviatan21 [X] (Inactive) added a comment - Perhaps it should be asked at another place : It could change the column bbcode_id to MEDIUMINT and it does not affect the rest of the code? Thanks
          Hide
          stokerpiller stokerpiller [X] (Inactive) added a comment -

          This bug is still here in 3.0.7

          Show
          stokerpiller stokerpiller [X] (Inactive) added a comment - This bug is still here in 3.0.7
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Rebased on develop-olympus to fix conflicts in database updater.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Rebased on develop-olympus to fix conflicts in database updater.

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              leviatan21 leviatan21 [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development