Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7707

Missing occurrences of get_username_string

    Details

      Description

      There are some locations that are missing the get_username_string() function for username links.

      /includes/acp/acp_main.php:44

                  $perm_from = '<strong' . (($user_row['user_colour']) ? ' style="color: #' . $user_row['user_colour'] . '">' : '>');            $perm_from .= ($user_row['user_id'] != ANONYMOUS) ? '<a href="' . append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $user_row['user_id']) . '">' : '';            $perm_from .= $user_row['username'];            $perm_from .= ($user_row['user_id'] != ANONYMOUS) ? '</a>' : '';            $perm_from .= '</strong>'; 

      /includes/acp/acp_prune.php:303

      'U_PROFILE'            => append_sid($phpbb_root_path . 'memberlist.' . $phpEx, 'mode=viewprofile&amp;u=' . $user_id), 

      /includes/acp/auth.php:652

                              'USERNAME'        => $row['username'],                        'U_PROFILE'        => append_sid("{$phpbb_root_path}memberlist.$phpEx", "mode=viewprofile&amp;u={$row['user_id']}")) 

      /includes/functions_admin.php:2343

      $profile_url = (defined('IN_ADMIN')) ? append_sid("{$phpbb_admin_path}index.$phpEx", 'i=users&amp;mode=overview') : append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile'); 

      /includes/mcp/mcp_front.php:106

      'U_AUTHOR'            => ($row['poster_id'] == ANONYMOUS) ? '' : append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $row['poster_id']),[...]'AUTHOR'        => ($row['poster_id'] == ANONYMOUS) ? (($row['post_username']) ? $row['post_username'] : $user->lang['GUEST']) : $row['username'], 

      /includes/mcp/mcp_post.php:276

      'REPORTER'        => ($row['user_id'] != ANONYMOUS) ? $row['username'] : $user->lang['GUEST'],                    'U_REPORTER'    => ($row['user_id'] != ANONYMOUS) ? append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $row['user_id']) : '', 

      /includes/mcp/mcp_post.php:336

                          'USERNAME'        => ($user_id == ANONYMOUS) ? $user->lang['GUEST'] : $user_row['username'],[...]                    'U_PROFILE'        => ($user_id == ANONYMOUS) ? '' : append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $user_id), 

      /includes/mcp/mcp_warn.php:99

                      'USERNAME_FULL'        => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),                'USERNAME'            => $row['username'],                'USERNAME_COLOUR'    => ($row['user_colour']) ? '#' . $row['user_colour'] : '',                'U_USER'            => append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $row['user_id']), 

      /includes/mcp/mcp_warn.php:121

                      'USERNAME_FULL'        => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),                'USERNAME'            => $row['username'],                'USERNAME_COLOUR'    => ($row['user_colour']) ? '#' . $row['user_colour'] : '',                'U_USER'            => append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $row['user_id']), 

      /includes/mcp/mcp_warn.php:169

                      'USERNAME_FULL'        => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),                'USERNAME'            => $row['username'],                'USERNAME_COLOUR'    => ($row['user_colour']) ? '#' . $row['user_colour'] : '',                'U_USER'            => append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $row['user_id']), 

      There are also a few locations in the following files that have links to usernames that are either $server_url or generate_board_url within BBCode. I'm not sure if it would make sense to change those, but thought I would mention it regardless:
      ucp_pm_compose.php
      ucp_profile.php
      ucp_register.php
      ucp_resend.php

      memberlist.php:1432

      'U_VIEW_PROFILE'    => append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=viewprofile&amp;u=' . $user_id)) 

      viewtopic.php:1080

      'profile'        => append_sid("{$phpbb_root_path}memberlist.$phpEx", "mode=viewprofile&amp;u=$poster_id"), 

        Issue Links

          Activity

          Hide
          ToonArmy Chris Smith added a comment -

          The ones in ucp_profile.php and ucp_register.php are sent in e-mails

          Show
          ToonArmy Chris Smith added a comment - The ones in ucp_profile.php and ucp_register.php are sent in e-mails
          Hide
          Highway of Life David Lewis [X] (Inactive) added a comment -

          and ucp_resend.php ... but it could still use the $mode = 'profile' and set the $custom_profile_url args, that's just the part I'm not sure will make a whole lot of sense, as it is basically a function overhead.

          Show
          Highway of Life David Lewis [X] (Inactive) added a comment - and ucp_resend.php ... but it could still use the $mode = 'profile' and set the $custom_profile_url args, that's just the part I'm not sure will make a whole lot of sense, as it is basically a function overhead.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Highway of Life David Lewis [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development