Details
Bug
Major
Description
Hi devs,
even if I try to export any style component by choosing any
TAR format, it results in a damaged archive. ZIP archiving works smoothly. (tested with Total Commander 7 and WinRAR 3.7)
Best regards
easygo
Activity
Could you upload or make available for download a tar file which is broken so we can investigate. Thanks.
Experienced strange behaviour when exporting templates.
Templates seem to exist multiple times in the export. I choose to download the .zip export.
Breadcrumbs.html exists 140 times and in only two versions. 139 times with CRC: D1A6B4B7 and just 1 time with CRC: D96D161F.
When unpacking an overwrite confirmation is popping up. Which is to be expected in this case.
Same thing happens when exporting templates to a .tar or .zip in /store
Please advice
Using phpBB 3.0.6
Did the auto update from 3.0.4 to 3.0.6
I don't know if this behaviour was present before the update.
On a closer look, the facts about the 2 "types" of tar file (store/download) are:
they will have different MD5s and BOTH will not open in Windows (IZarc, 7-Zip), whereas both test fine under Linux. (tar tf)
As far as the difference between store and download versions are concerned, I found only differences in what I believe are timestamps of the files inside the tar, so in fact both files are identical.
Not sure why Windows is choking on them.
Using the attached prosilver.tar file, I was able to get the file to open simply by changing the line endings to UNIX in my text editor. I'm not sure at this point how that affects anything, and why it would not affect other applications of the compress_tar class.
This might be caused by a broken function on the compress-class.Language files seem to be exporting correctly.
because language uses
// Add file to archive
|
$compress->add_custom_file($phpbb_root_path . $source, $destination);
|
foreach ($files as $file_ary)
|
{
|
$compress->add_file($file_ary['src'], $file_ary['prefix-'], $file_ary['prefix+'], $file_ary['exclude']);
|
}
|
You can work around, by replacing the
$compress->add_file($file_ary['src'], $file_ary['prefix-'], $file_ary['prefix+'], $file_ary['exclude']);
|
$dir_files = filelist($phpbb_root_path . $file_ary['src'], '', '*');
|
$dir_files = (isset($dir_files[''])) ? $dir_files[''] : array();
|
|
|
$src_path = ($file_ary['prefix-']) ? preg_replace('#^(' . preg_quote($file_ary['prefix-'], '#') . ')#', '', $file_ary['src']) : $file_ary['src'];
|
$src_path = ($file_ary['prefix+']) ? ($file_ary['prefix+'] . ((substr($file_ary['prefix+'], -1) != '/') ? '/' : '') . $src_path) : $src_path;
|
$src_path = (substr($src_path, 0, 1) == '/') ? substr($src_path, 1) : $src_path;
|
|
|
foreach ($dir_files as $file)
|
{
|
if (strpos($file_ary['exclude'], $file) === false)
|
{
|
$compress->add_custom_file($phpbb_root_path . $file_ary['src'] . $file, $src_path . $file);//($file_ary['src'], $file_ary['prefix-'], $file_ary['prefix+'], $file_ary['exclude']);
|
}
|
}
|
but the existing function must be fixed.
Add the folders to the archive before putting the files inside, seems to break the tar-archives.
Okay, seems this is only broken for templates. Using under windows, winrar and 7zip both report invalid archive. p7zip under Linux works fine. Language files seem to be exporting correctly.