Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7291

Broken links of char selection in memberlist

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.1
    • Fix Version/s: 3.0.10-RC1
    • Labels:
      None
    • Environment:
      PHP Environment: 5
      Database: 5

      Description

      The links are generated like this in the template:

      <a href="

      {S_MODE_ACTION}

      &first_char=a#memberlist">A</a>

      This brokes the urls!!!
      Easy to reproduce:
      1. Enter http://www.phpbb.com/community/memberlist.php
      The link for letter A is:
      http://www.phpbb.com/community/memberlist.php?mode=&first_char=a#memberlist

      2. Now click letter A, the link for A is now:
      http://www.phpbb.com/community/memberlist.php?first_char=a&mode=&first_char=a#memberlist

      Besides empty 'mode' var shouldn't be used here (mode=)

        Issue Links

          Activity

          Hide
          Dionisiy Dionisiy added a comment -

          S_MODE_ACTION template var should already have the first_char parameter, so the template url will be :
          <a href="

          {S_MODE_ACTION_A}

          #memberlist">A</a>

          Show
          Dionisiy Dionisiy added a comment - S_MODE_ACTION template var should already have the first_char parameter, so the template url will be : <a href=" {S_MODE_ACTION_A} #memberlist">A</a>
          Hide
          angelside angelside [X] (Inactive) added a comment -

          First click A, after click D, url seem below, but only display first latter, this is maybe a bug, or this options show A and D, but this idea not works

          memberlist.php?first_char=d?first_char=a#memberlist

          Show
          angelside angelside [X] (Inactive) added a comment - First click A, after click D, url seem below, but only display first latter, this is maybe a bug, or this options show A and D, but this idea not works memberlist.php?first_char=d?first_char=a#memberlist
          Hide
          Dionisiy Dionisiy added a comment -

          This is the bug with the urls, part of url is generated with append_sid n the core file, another part with the letter is added right in the template.

          I think all urls should be generated in the core file via append_sid function and template should just render the template url variables.

          Show
          Dionisiy Dionisiy added a comment - This is the bug with the urls, part of url is generated with append_sid n the core file, another part with the letter is added right in the template. I think all urls should be generated in the core file via append_sid function and template should just render the template url variables.
          Hide
          leviatan21 leviatan21 [X] (Inactive) added a comment -

          *Changelog : *[Fix] Correctly display links in memberlist. (PHPBB3-7291 - Patch by leviatan21)

          Show
          leviatan21 leviatan21 [X] (Inactive) added a comment - *Changelog : * [Fix] Correctly display links in memberlist. (PHPBB3-7291 - Patch by leviatan21)
          Hide
          nickvergessen Joas Schilling added a comment -

          forgot the diff?

          Show
          nickvergessen Joas Schilling added a comment - forgot the diff?
          Hide
          leviatan21 leviatan21 [X] (Inactive) added a comment -

          This patch will also fix the [bug:1udwpbqt]48815[/bug:1udwpbqt]

          Show
          leviatan21 leviatan21 [X] (Inactive) added a comment - This patch will also fix the [bug:1udwpbqt] 48815 [/bug:1udwpbqt]

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Dionisiy Dionisiy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development