Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-4412

MCP and viewtopic messed up when long profile fields used

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.x
    • Fix Version/s: 3.1.0-a1
    • Component/s: Styles
    • Labels:
      None

      Description

      Don't know if that counts as bug:
      Create a custom profile field which allows a large number of characters.
      It flows out of the MCP box (screenshot 1) and - worse - out of the "box" on viewtopic (screenshot 2). The latter case could be prevented by adding overflow: hidden; to .postprofile.
      For the first one, removing autowidth from the class attribute seems to help.
      (Side note: in ACP, it does not overflow; there's no autowidth either but: max-width: 100%

      1. custom_profile_fields_zoomed.png
        7 kB
      2. custom_profile_fields.png
        5 kB
      3. post_signature.png
        4 kB
      4. profile_field_acp.png
        1.0 kB
      5. profile_field_mcp.png
        4 kB
      6. profile_field_viewtopic.png
        8 kB

        Issue Links

          Activity

          Hide
          cyberalien cyberalien added a comment -

          Try entering something that makes sense, not just "wwwwwwwwwwwwwwwwwwwwwwww". Noone enters such data other than for testing.

          Show
          cyberalien cyberalien added a comment - Try entering something that makes sense, not just "wwwwwwwwwwwwwwwwwwwwwwww". Noone enters such data other than for testing.
          Hide
          Skeetergirl Skeetergirl [X] (Inactive) added a comment -

          I agree! A simple space and.... "we got a wrap"!

          Show
          Skeetergirl Skeetergirl [X] (Inactive) added a comment - I agree! A simple space and.... "we got a wrap"!
          Hide
          dark/Rain dark/Rain [X] (Inactive) added a comment -

          Expected that somehow...
          Better example: screenshot
          Worse when the pages gets zoomed (Firefox at least; screenshot 2).

          And it does not necessarily have to be by accident, someone could just enter something not containing a whitespace to mess it up.
          In posts and signatures, the text gets "cropped", too (screenshot 3).

          Show
          dark/Rain dark/Rain [X] (Inactive) added a comment - Expected that somehow... Better example: screenshot Worse when the pages gets zoomed (Firefox at least; screenshot 2). And it does not necessarily have to be by accident, someone could just enter something not containing a whitespace to mess it up. In posts and signatures, the text gets "cropped", too (screenshot 3).
          Hide
          dark/Rain dark/Rain [X] (Inactive) added a comment -

          ...and I did not wonder why it doesn't wrap!

          Show
          dark/Rain dark/Rain [X] (Inactive) added a comment - ...and I did not wonder why it doesn't wrap!
          Hide
          Raimon Raimon Meuldijk added a comment -

          It is not really a bug, but more a bug for on the case users are going create such fields.
          I really doubt that users are creating such long fields.

          I suggested this fix ;

          open /styles/prosilver/template/custom_profile_fields.html

          search:

          <!-- BEGIN string -->
          <input type="text" class="inputbox autowidth" name="{string.FIELD_IDENT}" id="{string.FIELD_IDENT}" size="{string.FIELD_LENGTH}" maxlength="{string.FIELD_MAXLEN}" value="{string.FIELD_VALUE}" />
          <!-- END string -->

          replace with:

          <!-- BEGIN string -->
          <input type="text" class="inputbox" name="{string.FIELD_IDENT}" id="{string.FIELD_IDENT}" size="{string.FIELD_LENGTH}" maxlength="{string.FIELD_MAXLEN}" value="{string.FIELD_VALUE}" />
          <!-- END string -->

          To make the fields looks the same on the rest ( with autowidth the input box is smaller then the rest )

          search:

          <!-- BEGIN text -->
          <textarea name="{text.FIELD_IDENT}" id="{text.FIELD_IDENT}" rows="{text.FIELD_ROWS}" cols="{text.FIELD_COLS}" class="inputbox autowidth">{text.FIELD_VALUE}</textarea>
          <!-- END text -->

          replace with:

          <!-- BEGIN text -->
          <textarea name="{text.FIELD_IDENT}" id="{text.FIELD_IDENT}" rows="{text.FIELD_ROWS}" cols="{text.FIELD_COLS}" class="inputbox">{text.FIELD_VALUE}</textarea>
          <!-- END text -->

          search:

          <!-- BEGIN int -->
          <input type="text" class="inputbox autowidth" name="{int.FIELD_IDENT}" id="{int.FIELD_IDENT}" size="{int.FIELD_LENGTH}" value="{int.FIELD_VALUE}" />
          <!-- END int -->

          replace with:

          <!-- BEGIN int -->
          <input type="text" class="inputbox" name="{int.FIELD_IDENT}" id="{int.FIELD_IDENT}" size="{int.FIELD_LENGTH}" value="{int.FIELD_VALUE}" />
          <!-- END int -->

          On the viewtopic view this would fix it

          open content.css

          search:

          .postprofile dd, .postprofile dt {
          	line-height: 1.2em;
          	margin-left: 8px;
          }

          replace with:

          .postprofile dd, .postprofile dt {
          	line-height: 1.2em;
          	margin-left: 8px;
             overflow: hidden;
          }

          Show
          Raimon Raimon Meuldijk added a comment - It is not really a bug, but more a bug for on the case users are going create such fields. I really doubt that users are creating such long fields. I suggested this fix ; open /styles/prosilver/template/custom_profile_fields.html search: <!-- BEGIN string --> <input type="text" class="inputbox autowidth" name="{string.FIELD_IDENT}" id="{string.FIELD_IDENT}" size="{string.FIELD_LENGTH}" maxlength="{string.FIELD_MAXLEN}" value="{string.FIELD_VALUE}" /> <!-- END string --> replace with: <!-- BEGIN string --> <input type="text" class="inputbox" name="{string.FIELD_IDENT}" id="{string.FIELD_IDENT}" size="{string.FIELD_LENGTH}" maxlength="{string.FIELD_MAXLEN}" value="{string.FIELD_VALUE}" /> <!-- END string --> To make the fields looks the same on the rest ( with autowidth the input box is smaller then the rest ) search: <!-- BEGIN text --> <textarea name="{text.FIELD_IDENT}" id="{text.FIELD_IDENT}" rows="{text.FIELD_ROWS}" cols="{text.FIELD_COLS}" class="inputbox autowidth">{text.FIELD_VALUE}</textarea> <!-- END text --> replace with: <!-- BEGIN text --> <textarea name="{text.FIELD_IDENT}" id="{text.FIELD_IDENT}" rows="{text.FIELD_ROWS}" cols="{text.FIELD_COLS}" class="inputbox">{text.FIELD_VALUE}</textarea> <!-- END text --> search: <!-- BEGIN int --> <input type="text" class="inputbox autowidth" name="{int.FIELD_IDENT}" id="{int.FIELD_IDENT}" size="{int.FIELD_LENGTH}" value="{int.FIELD_VALUE}" /> <!-- END int --> replace with: <!-- BEGIN int --> <input type="text" class="inputbox" name="{int.FIELD_IDENT}" id="{int.FIELD_IDENT}" size="{int.FIELD_LENGTH}" value="{int.FIELD_VALUE}" /> <!-- END int --> On the viewtopic view this would fix it open content.css search: .postprofile dd, .postprofile dt { line-height: 1.2em; margin-left: 8px; } replace with: .postprofile dd, .postprofile dt { line-height: 1.2em; margin-left: 8px; overflow: hidden; }
          Hide
          bantu Andreas Fischer added a comment -

          Inline patch by Raimon.

          Show
          bantu Andreas Fischer added a comment - Inline patch by Raimon.
          Hide
          Arty Vjacheslav Trushkin added a comment -

          Patch for 3.1-dev

          Show
          Arty Vjacheslav Trushkin added a comment - Patch for 3.1-dev

            People

            • Assignee:
              EXreaction EXreaction [X] (Inactive)
              Reporter:
              unknown user unknown user
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development