Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-17044

Possible Incorrect If Statement For Forum Description & Moderators In viewforum.html

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 3.3.8
    • None
    • Styles
    • None

    Description

      The forum description and moderators list can be shown in both the view forum and the view topic pages, however the if statement for them in the view forum template seems to have a mistake in it

       

      viewforum_body.html 

      <!-- IF FORUM_DESC or MODERATORS or U_MCP --> 

      Should the 'or U_MCP' bit bit there? or should it just be:

      <!-- IF FORUM_DESC or MODERATORS --> 

       

       

      Also, the forum description and moderators list are coded differently on the view forum template and the view topic template, in viewforum_body.html they are contained in a div but in viewtopic_body.html they are not.

       

      viewforum_body.html 

      <!-- IF FORUM_DESC or MODERATORS or U_MCP -->
      <div>
          <!-- NOTE: remove the style="display: none" when you want to have the forum description on the forum body -->
          <!-- IF FORUM_DESC --><div style="display: none !important;">{FORUM_DESC}<br /></div><!-- ENDIF -->
          <!-- IF MODERATORS --><p><strong><!-- IF S_SINGLE_MODERATOR -->{L_MODERATOR}<!-- ELSE -->{L_MODERATORS}<!-- ENDIF -->{L_COLON}</strong> {MODERATORS}</p><!-- ENDIF -->
      </div>
      <!-- ENDIF -->

       

      viewtopic_body.html

       

      <!-- NOTE: remove the style="display: none" when you want to have the forum description on the topic body -->
      <!-- IF FORUM_DESC --><div style="display: none !important;">{FORUM_DESC}<br /></div><!-- ENDIF -->
      <!-- IF MODERATORS -->
      <p>
          <strong><!-- IF S_SINGLE_MODERATOR -->{L_MODERATOR}<!-- ELSE -->{L_MODERATORS}<!-- ENDIF -->{L_COLON}</strong> {MODERATORS}
      </p>
      <!-- ENDIF -->
      

       

      Should they both be the same for consistency? 

      Attachments

        Activity

          People

            Unassigned Unassigned
            ForumFlair ForumFlair
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: