Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-17032

Missing or invalid user entry for anonymous user may result in stack overflow

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.3.8
    • 3.3.9-RC1
    • None
    • None

    Description

      The user_loader's get_user() method does try to fall back to the anonymous user if a certain user couldn't be loaded. It does so by calling itself:

      https://github.com/phpbb/phpbb/blob/master/phpBB/phpbb/user_loader.php#L138

      According to the docblock, it should return "False if the anonymous user was not loaded". That is however not true. When the anonymous user was not loaded, it will try loading the anonymous user and call itself again to return the user data. However, in cases where the anonymous user's data couldn't be retrieved, it'll just continue calling itself.

      This then results in a stack overflow and a segmentation fault for PHP.

      Attachments

        Activity

          People

            Marc Marc
            Marc Marc
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: