Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-16698

Check for default char set in includes/acp_main.php checks only for 'UTF-8'

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.3.4-RC1
    • Component/s: ACP
    • Labels:

      Description

      The (new) check for the default character set in 3.3.3 just looks for the string 'UTF-8' and if it isn't found a red error message is displayed at ACP's General tab.

      This happens even if this is the default char set but the PHP variable is spelled in lower case (which was the case when I updated from 3.3.2 to 3.3.3).

      By changing acp_main.php, line 707 from

      'S_DEFAULT_CHARSET_FAIL' => $default_charset !== 'UTF-8',

      to

      'S_DEFAULT_CHARSET_FAIL' => strtolower($default_charset) !== 'utf-8',

      this error message could be prevented

        Attachments

          Activity

            People

            Assignee:
            Marc Marc
            Reporter:
            Mike-on-Tour Mike-on-Tour
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: