Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-16565

Circular dependencies when cron task depends on controller.helper

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.3.2-RC1
    • Component/s: Cron
    • Labels:
      None

      Description

      This PR added the cron.manager dependency to the controller.helper service. This can lead to cyclic dependencies when a cron task depends on the controller.helper service. I've attached a minimal extension to reproduce the problem. The issue is not limited to extensions though.

      Expected error message:

      Circular reference detected for service "kasimi.circrefin331.cron.task.sample", path: "kasimi.circrefin331.cron.task.sample -> controller.helper -> cron.manager -> kasimi.circrefin331.cron.task.sample".

      Real world example: while having both mChat and ABBC3 extensions enabled, mChat's cron task can't be executed and throws an error because of circular references:

      dmzx.mchat.cron.task.mchat_prune
      -> text_formatter.s9e.parser
      -> controller.helper
      -> cron.manager
      -> cron.task_collection
      -> dmzx.mchat.cron.task.mchat_prune

       

        Attachments

          Activity

            People

            Assignee:
            Marc Marc
            Reporter:
            kasimi kasimi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: