Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-16479

Trailing comma in "Allowed schemes in links:" kills board

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Duplicate
    • 3.2.9, 3.3.0
    • None
    • ACP
    • None

    Description

      ACP > Post settings > Allowed schemes in links: "http, https, ftp"

      "http, https, ftp" is standard, the user can change the input. Any trailing space e.g. "http, https," will lead immediatly to a FATAL ERROR and the board is no longer accessible.

      PHP Fatal error:  Uncaught InvalidArgumentException: Invalid scheme name '' in /vendor/s9e/text-formatter/src/Configurator.php:8456
      Stack trace:
      /vendor/s9e/text-formatter/src/Configurator.php(8112): s9e\\TextFormatter\\Configurator\\Collections\\SchemeList->normalizeValue('')
      /vendor/s9e/text-formatter/src/Configurator.php(8147): s9e\\TextFormatter\\Configurator\\Collections\\NormalizedList->append('')
      /vendor/s9e/text-formatter/src/Configurator.php(7220): s9e\\TextFormatter\\Configurator\\Collections\\NormalizedList->offsetSet(NULL, '')
       /phpbb/textformatter/s9e/factory.php(223): s9e\\TextFormatter\\Configurator\\UrlConfig->allowScheme('')
      /phpbb/textformatter/s9e/factory.php(389): phpbb\\te in /vendor/s9e/text-formatter/src/Configurator.php on line 8456
      

      So this input should be blocked or filtered, to avoid such a problem.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Crizzo Crizzo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: