Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-16235

Ignore patterns in ext-sniff.sh are not processed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3.0-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      With the current 3.3.x branch, the ignore patterns specified in the file ext-sniff.sh are not being processed.

       I have an extension that requires an third-party extension from Packagist, and it's throwing errors about files inside the vendor directory.

      FILE: ...edoramos/imgur/vendor/j0k3r/php-imgur-api-client/lib/Imgur/Auth/OAuth2.php
       
      --------------------------------------------------------------------------------
       
      FOUND 205 ERRORS AFFECTING 200 LINES
       
      --------------------------------------------------------------------------------
       
         1 | ERROR | [ ] Filename "OAuth2.php" doesn't match the expected filename
       
           |       |     "oauth2.php" (Generic.Files.LowercasedFilename.NotFound)
       
        15 | ERROR | [x] Tabs must be used to indent lines; spaces are not
       
           |       |     allowed
       
           |       |     (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed)
      

      https://travis-ci.org/AlfredoRamos/phpbb-ext-imgur/jobs/618052193#L625

        Attachments

          Activity

            People

            Assignee:
            Marc Marc
            Reporter:
            AbaddonOrmuz AbaddonOrmuz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: