Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-15740

Terms & Privavy hardcoded

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Unverified Fix (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.3-RC2
    • Fix Version/s: 3.2.3
    • Component/s: Styles
    • Labels:
      None

      Description

      why are Terms & Privavy hardcoded in overall_footer.html instead of using the language strings?

      Link to style changes:
      https://gist.github.com/marc1706/e53313e6b38bb7ab8280c8e7e8c72c40#file-prosilver_changes_3-2-2_to_3-2-3-rc2-html-diff-L22

      'PRIVACY_LINK'			=> 'Privacy',
      'TERMS_LINK'		=> 'Terms',
      

      +			<a class="footer-link" href="{{ U_PRIVACY }}" title="{{ lang('PRIVACY_LINK') }}" role="menuitem">
      				<span class="footer-link-text">Privacy</span>
      			</a>
      			|
      			<a class="footer-link" href="{{ U_TERMS_USE }}" title="{{ lang('TERMS_LINK') }}" role="menuitem">
      				<span class="footer-link-text">Terms</span>
      			</a>
      

        Attachments

          Activity

            People

            Assignee:
            Marc Marc
            Reporter:
            Froddelaar Froddelaar [X] (Inactive)
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: