Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-15642

String to be used in HTML element contains ">"

    Details

    • Type: Improvement
    • Status: Unverified Fix (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.2.2
    • Fix Version/s: 3.2.4-RC1
    • Component/s: Language pack
    • Labels:
      None

      Description

      The following string contains two ">":

          'CONTACT_US_ENABLE_EXPLAIN'        => 'This page allows users to send emails to board administrators. Please note that board-wide emails option must be enabled as well. You can find this option in General > Client Communication > Email settings.',

      Found in:

      phpbb\phpBB\language\en\acp\board.php

       

      But its used in HTML so should either be "& gt;" or find some other way of writing it.

       

      I would not recommend writing "General > Client Communication > Email settings" because then translators would have to make sure those strings are the same in more then one place.

      Would be better to use placeholders/variables to reuse the strings that have already been translated.

       

      General > Client Communication > Email settings

      To:

      {L_ACP_CAT_GENERAL}

      > {L_ACP_CLIENT_COMMUNICATION} > {L_ACP_EMAIL_SETTINGS}

      Or how ever its done.

       

      Perhaps make part of the text a link for easier access.

      Maybe delete the "General > Client Communication > " if its made to be a link.

        Attachments

          Activity

            People

            • Assignee:
              Marc Marc
              Reporter:
              scootergrisen scootergrisen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: