Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-15540

Refactor search backend classes to Symfony services

    Details

    • Type: Task
    • Status: Patch Awaiting Review (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.0.0-a1
    • Fix Version/s: None
    • Component/s: Search
    • Labels:
      None

      Description

      Currently, the search backend classes are instantiated manually where needed. This should be changed to using Symfony services.

       
      The class name of the active search backend is stored in the config field search_type. phpBB ships with these 4 search backends:

      • \phpbb\search\fulltext_native
      • \phpbb\search\fulltext_mysql
      • \phpbb\search\fulltext_postgres
      • \phpbb\search\fulltext_sphinx

      In a new migration, the class names should be converted to these service names:

      • search.fulltext.native
      • search.fulltext.mysql
      • search.fulltext.postgres
      • search.fulltext.sphinx

      A new search.factory service should take care of instantiating the currently active search backend, and optionally allow instantiating any of the available search backends.

        Attachments

          Activity

            People

            • Assignee:
              rubencm rubencm
              Reporter:
              kasimi kasimi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: