Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-15478

core.js $loadingIndicator JavaScript errors

    XMLWordPrintable

    Details

      Description

      Two issues with the following statement:

      $loadingIndicator = $('<div />', { 
          id: 'loading_indicator', 
          class: 'loading_indicator', 
      });
      

      1. id and class are keywords that require string delimiters if they are to be object keys according to some validators (and thus potentially some browsers).
      2. The trailing comma has compatibility issues on older browsers, and isn't used elsewhere in the codebase as far as I've looked.

        Attachments

          Activity

            People

            Assignee:
            Marc Marc
            Reporter:
            dsinn dsinn [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: