Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-14801

Search highlight option doesn't always highlight unicode strings

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.1.10-RC1, 3.2.0-dev, 4.0.0-a1
    • 3.1.11-RC1
    • Search
    • None

    Description

      The regular expressions used for search results highlighting here https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/search.php#L1063 and here https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/search.php#L1146-L1147 don't use unicode options. This leads to highlighting may miss unicode strings as \w sequence recognizes only characters with codes less than 128 via a lookup table.
      Adding u option should make \w using Unicode properties to determine character types.

      Attachments

        Activity

          People

            nicofuma nicofuma
            rxu rxu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: