Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-14598

Phing Sniffer Testing Use Statements in DocBlocks

    Details

    • Type: Task
    • Status: Unverified Fix (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.10-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      Phing-sniff will consider a Use statement unused if it is only being used in a docblock, i.e.:

      use Foo\Bar\FooBar

      /* @var FooBar */

      It should be updated to recognize the statement is in fact used, to prevent test failures.

      Example failure: https://travis-ci.org/phpbb/phpbb/jobs/122583594#L940
      This is the usage: https://github.com/VSEphpbb/phpbb/blob/ticket/14569/phpBB/phpbb/console/command/user/reclean.php#L36

        Attachments

          Activity

            People

            • Assignee:
              nicofuma nicofuma
              Reporter:
              VSE VSE
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: