Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-14540

Adjust class recursive_dot_prefix_filter_iterator to increase performance

    XMLWordPrintable

Details

    • Improvement
    • Status: Unverified Fix (View Workflow)
    • Trivial
    • Resolution: Fixed
    • 3.1.8, 3.2.0-b2
    • 3.1.9-RC1, 3.2.0-RC1
    • Other
    • None

    Description

      Swapping conditions in the function accept() of the class \phpbb\recursive_dot_prefix_filter_iterator saves a lot of isDir() calls which is more expensive than $filename[0] checks.

      https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/phpbb/recursive_dot_prefix_filter_iterator.php#L28

      Attachments

        Activity

          People

            nicofuma nicofuma [X] (Inactive)
            rxu rxu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: