Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-14540

Adjust class recursive_dot_prefix_filter_iterator to increase performance

    Details

    • Type: Improvement
    • Status: Unverified Fix (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.1.8, 3.2.0-b2
    • Fix Version/s: 3.1.9-RC1, 3.2.0-RC1
    • Component/s: Other
    • Labels:
      None

      Description

      Swapping conditions in the function accept() of the class \phpbb\recursive_dot_prefix_filter_iterator saves a lot of isDir() calls which is more expensive than $filename[0] checks.

      https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/phpbb/recursive_dot_prefix_filter_iterator.php#L28

        Attachments

          Activity

            People

            • Assignee:
              nicofuma nicofuma
              Reporter:
              rxu rxu
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: