Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-14470

Atom feed category element incorrectly controlled by feed_item_statistics configuration setting

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 3.1.6
    • None
    • Other
    • None
    • CentOS Linux release 7.2.1511 (Core), PHP 5.4.16, 5.5.44-MariaDB.

    Description

      In ACP->Feed settings the General feed setting Item statistics is indicated to Display individual statistics underneath feed items (e.g. posted by, date and time, replies, views).

      The Atom:category Elements portion of the feed are not part of the "individual statistics underneath feed items", but if Item statistics is disabled then they are omitted from the feed. They should therefore always be part of the feed, regardless of the setting of Item statistics.

      feed.php should be changed as follows to allow the Category element to be part of the feed, without regard to whether Item statistics is enabled or disabled.

      116,117c116,117
      <               'category'              => ($config['feed_item_statistics'] && !empty($row['forum_id'])) ? $board_url . '/viewforum.' . $phpEx . '?f=' . $row['forum_id'] : '',
      <               'category_name' => ($config['feed_item_statistics'] && isset($row['forum_name'])) ? $row['forum_name'] : '',
      ---
      >               'category'              => (!empty($row['forum_id'])) ? $board_url . '/viewforum.' . $phpEx . '?f=' . $row['forum_id'] : '',
      >               'category_name' => (isset($row['forum_name'])) ? $row['forum_name'] : '',
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            P_I P_I
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: