Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13984

AJAX Loading Indicator broken

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.5
    • Fix Version/s: 3.1.6-RC1
    • Component/s: None
    • Labels:
      None

      Description

      Changes in 3.1.5 to the loading indicator in assets/core.js have broken it.

      Now, for example, when data-overlay="false" you get the JS error:
      TypeError: undefined is not an object (evaluating '$loadingIndicator.fadeOut')

      Caused by this change: https://github.com/phpbb/phpbb/commit/d978564600032cf599ef8e0352cdeb60312b2a10

      Error comes from
      https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/assets/javascript/core.js#L398

        Attachments

          Issue Links

          was caused by solution of

          Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-13905 loading.gif loaded before document load when it isn't needed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

              People

              • Assignee:
                Marc Marc
                Reporter:
                VSE Matt Friedman
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: