Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13938

Incomplete fixes in prosilver in 3.1.5-RC1 and incomplete code changes

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.5-RC1
    • Fix Version/s: 3.1.5
    • Component/s: Styles
    • Labels:
      None

      Description

      Few pull requests were merged in prosilver in 3.1.5-RC1 that change code in overall_header.html in head section: https://tracker.phpbb.com/browse/PHPBB3-13873 and https://tracker.phpbb.com/browse/PHPBB3-13876

      In both tickets fixes were incomplete: changes were not applied to simple_header.html

      Additionally, link code was changed from <link /> to <link>, but it was changed only for few elements, which makes code inconsistent. Since <link> is better suited for html doctype, the rest of entries should be changed as well.

        Attachments

          Issue Links

          was caused by solution of

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-13873 Remove broken print stylesheet in preference of &view=print

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-13876 Use async webfontloader to load webfont from googles CDN

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Unverified Fix

            Activity

              People

              • Assignee:
                nickvergessen Joas Schilling [X] (Inactive)
                Reporter:
                Arty Vjacheslav Trushkin [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: