Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13857

Refactor custom bbcodes to not use /e modifier in regex

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.2.0-dev
    • 3.2.0
    • BBCode Engine
    • None

    Description

      The current custom bbcode system that is used in acp_bbcodes and the message parser uses the /e modifier with preg_replace. This is no longer supported in PHP7.

      Since the regex for the custom bbcodes is generated and saved in the database, one cannot simply use anonymous functions for getting rid of the /e modifier. We'll have to modify the creation of the regex to run upon parsing the code instead of while creating the bbcode. Only then we'll be able to replace the occurences of the /e modifier with preg_replace_callback().

      We might want to use a token based system for that.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-13746 Creating BBCodes in PHP 7 will Fail because of e modifier

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-13932 preg_replace(): The /e modifier is no longer supported in php7

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Task - A task that needs to be done. PHPBB3-13832 Replace use of deprecated e modifier of preg_replace in bbcode functions

          • Major - Major loss of function.
          • Unverified Fix

          Activity

            People

              nicofuma nicofuma
              Marc Marc
              Votes:
              4 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: