Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13857

Refactor custom bbcodes to not use /e modifier in regex

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0-dev
    • Fix Version/s: 3.2.0
    • Component/s: BBCode Engine
    • Labels:
      None

      Description

      The current custom bbcode system that is used in acp_bbcodes and the message parser uses the /e modifier with preg_replace. This is no longer supported in PHP7.

      Since the regex for the custom bbcodes is generated and saved in the database, one cannot simply use anonymous functions for getting rid of the /e modifier. We'll have to modify the creation of the regex to run upon parsing the code instead of while creating the bbcode. Only then we'll be able to replace the occurences of the /e modifier with preg_replace_callback().

      We might want to use a token based system for that.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nicofuma nicofuma
                Reporter:
                Marc Marc
              • Votes:
                4 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: