[PHPBB3-13832] Replace use of deprecated e modifier of preg_replace in bbcode functions

XML

Word

Printable

Details

Type: Task
Status: Unverified Fix (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 3.1.4
Fix Version/s: 3.2.0-a1
Component/s: BBCode Engine
Labels:
None

GitHub Pull Request URL:
https://github.com/phpbb/phpbb/pull/3618

Description

I have found a few instances where the deprecated e modifier of preg_replace is being used in bbcode-related code:

https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/bbcode.php#L368
https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/bbcode.php#L492

https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/message_parser.php#L746
https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/message_parser.php#L1552
https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/message_parser.php#L1620
https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/message_parser.php#L1664

https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/acp/acp_bbcodes.php#L491
https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/includes/acp/acp_bbcodes.php#L556-L559

These should be converted to preg_replace_callback functions, and the rest of the codebase should be checked to verify that there are no more of these lurking anywhere. This should be done for PHP 7 forward compatibility.

Attachments

Issue Links

is duplicated by

PHPBB3-13746 Creating BBCodes in PHP 7 will Fail because of e modifier

Closed

PHPBB3-13932 preg_replace(): The /e modifier is no longer supported in php7

Closed

is related to

PHPBB3-13857 Refactor custom bbcodes to not use /e modifier in regex

Closed

Activity

People

Assignee:: Marc

Reporter:: omniError [X] (Inactive)

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 11/May/15 11:40 PM

Updated:: 08/Jul/15 8:05 AM

Resolved:: 24/Jun/15 2:36 PM