Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13805

Make generate_text_for_storage() match the signature and feature set of message_parser::parse()

    Details

    • Type: Improvement
    • Status: Unverified Fix (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0-dev
    • Fix Version/s: 3.2.0-a1
    • Component/s: Posting
    • Labels:
      None

      Description

      Current signatures:

      generate_text_for_storage(&$text, &$uid, &$bitfield, &$flags, $allow_bbcode = false, $allow_urls = false, $allow_smilies = false)
      parse($allow_bbcode, $allow_magic_url, $allow_smilies, $allow_img_bbcode = true, $allow_flash_bbcode = true, $allow_quote_bbcode = true, $allow_url_bbcode = true, $update_this_message = true, $mode = 'post')
      

      generate_text_for_storage() supports the following toggles: allow_bbcode, allow_urls, allow_smilies. All set to false.
      message_parser::parse() supports: allow_bbcode, allow_magic_url, allow_smilies (all three required parameters) plus allow_img_bbcode, allow_flash_bbcode, allow_quote_bbcode, allow_url_bbcode, which default to true.

      I propose to add those four extra parameters with a default value of true to match current behaviour.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nicofuma nicofuma
                Reporter:
                JoshyPHP JoshyPHP
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: