Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13633

Bug in acp_modules.php ver 3.0.13-PL1

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Invalid
    • 3.0.13-PL1
    • 3.0.15-RC1
    • ACP
    • None
    • PHP 5.4.24, MySQL 5.5.36-cll, Apache 2.4.10, Firefox 35.0.1

    Description

      When running phpBB 3.0.13-PL1 under php version 5.4 +, going to the "administrator panel, SYSTEM tab, and clicking MODULE MANAGEMENT, administrator control panel" generates lots of E_STRICT errors (static vs non-static) in module /acp/acp_modules.php at line 630.

      The solution I have adopted is to change the code thus:
      Replace lines 629 - 630 with:
      // We use zero as the forum id to check - global setting.
      (new p_master)->module_auth($row['module_auth']);
      if ('p_master' != 0)
      // if (!p_master::module_auth($row['module_auth'], 0))

      This seems to fix the problem caused by php 5.4's interpretation of calls with static vs non-static classes

      Attachments

        Activity

          People

            Marc Marc
            Steve Appleton Steve Appleton
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: