Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Invalid
    • Affects Version/s: 3.0.13-PL1, 3.1.3, 3.2.0-dev
    • Fix Version/s: 3.0.14-RC1, 3.1.4-RC1, 3.2.0-a1
    • Component/s: None
    • Labels:
      None

      Description

      Add a branch alias to the composer.json file for each branch

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        Can you please explain?

        Show
        nickvergessen Joas Schilling added a comment - Can you please explain?
        Hide
        bantu Andreas Fischer added a comment -

        Yes. Why?

        Show
        bantu Andreas Fischer added a comment - Yes. Why?
        Hide
        nickvergessen Joas Schilling added a comment -

        <MichaelC> nickvergessen: https://getcomposer.org/doc/articles/aliases.md
        <nickvergessen> MichaelC: we are going to rename our branches to match that
        <nickvergessen> so why use alias?
        <MichaelC> what?
        <MichaelC> Please re-read that page
        <nickvergessen> https://area51.phpbb.com/phpBB/viewtopic.php?f=99&t=47236
        <MichaelC> oh
        <nickvergessen> so obsoleted?
        <MichaelC> Still doesn't work the same way
        <MichaelC> as branch static names cannot use version constraints etc.
        <MichaelC> `3.*@dev` won't match a branch called `3.0.*`, a version alias will as they are proper versions/intelligent.
        <MichaelC> (I can't load that a51 page as chrome isn't loading for whatever reason)
        <MichaelC> so i'm guesing
        <nickvergessen> short version
        <nickvergessen> In line with other PHP projects (this proposal is also compatible with composer's branch version detection), I suggest we rename / reorganize these branches to the following:
        <nickvergessen>     3.0.x - Development of version 3.0.x
        <nickvergessen>     3.1.x - Development of version 3.1.x
        <nickvergessen>     master - Latest development version
        <MichaelC> yeah
        <MichaelC> so they are branch names
        <MichaelC> but for someone to use the version constraint 3.0.*@dev and have it grab the latest in the 3.0.x branch you need an alias
        <MichaelC> (Thanks for posting that here)
        <MichaelC> branch names are static
        <MichaelC> branch aliases allow for proper version comparison support
        <MichaelC> ah. composer can auto-detect branch names now. I didn't know that
        <MichaelC> nickvergessen: yes, it's obselete then except in the case of the master branch
        

        Show
        nickvergessen Joas Schilling added a comment - <MichaelC> nickvergessen: https://getcomposer.org/doc/articles/aliases.md <nickvergessen> MichaelC: we are going to rename our branches to match that <nickvergessen> so why use alias? <MichaelC> what? <MichaelC> Please re-read that page <nickvergessen> https://area51.phpbb.com/phpBB/viewtopic.php?f=99&t=47236 <MichaelC> oh <nickvergessen> so obsoleted? <MichaelC> Still doesn't work the same way <MichaelC> as branch static names cannot use version constraints etc. <MichaelC> `3.*@dev` won't match a branch called `3.0.*`, a version alias will as they are proper versions/intelligent. <MichaelC> (I can't load that a51 page as chrome isn't loading for whatever reason) <MichaelC> so i'm guesing <nickvergessen> short version <nickvergessen> In line with other PHP projects (this proposal is also compatible with composer's branch version detection), I suggest we rename / reorganize these branches to the following: <nickvergessen> 3.0.x - Development of version 3.0.x <nickvergessen> 3.1.x - Development of version 3.1.x <nickvergessen> master - Latest development version <MichaelC> yeah <MichaelC> so they are branch names <MichaelC> but for someone to use the version constraint 3.0.*@dev and have it grab the latest in the 3.0.x branch you need an alias <MichaelC> (Thanks for posting that here) <MichaelC> branch names are static <MichaelC> branch aliases allow for proper version comparison support <MichaelC> ah. composer can auto-detect branch names now. I didn't know that <MichaelC> nickvergessen: yes, it's obselete then except in the case of the master branch
        Hide
        bantu Andreas Fischer added a comment - - edited

        This wasn't implemented apparently. Ticket Resolution should not be "Fixed".

        Show
        bantu Andreas Fischer added a comment - - edited This wasn't implemented apparently. Ticket Resolution should not be "Fixed".

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            MichaelC Michael Cullum
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development