Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-13614

Remove phpbb_pcre_utf8_support() and assume Unicode is supported by PCRE

    XMLWordPrintable

Details

    • Improvement
    • Status: Unverified Fix (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.1.3
    • 3.2.0-a1
    • None
    • None

    Description

      Some parts of phpBB check for Unicode support in PCRE using phpbb_pcre_utf8_support(), others such as get_preg_expression() don't. I assume that Unicode support was not a requirement in the past and it now is.

      This PR removes those checks as well as dead code. You may want to keep phpbb_pcre_utf8_support() in 3.1 in case an extension relies on it.

      Attachments

        Activity

          People

            nicofuma nicofuma [X] (Inactive)
            JoshyPHP JoshyPHP
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: