Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13570

Mysqli extension supports persistent connection since PHP 5.3.0

    Details

    • Type: Bug
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 3.1.3
    • Fix Version/s: 3.1.4-RC1
    • Component/s: None
    • Labels:
      None

      Description

      In phpbb\db\driver\mysqli.php, the following lines:

      // Mysqli extension supports persistent connection since PHP 5.3.0
      $this->persistency = (version_compare(PHP_VERSION, '5.3.0', '>=')) ? $persistency : false;
      

      can be replaced with:

      $this->persistency = $persistency;

      in sql_connect().

        Activity

        Hide
        M.Gaetan89 M.Gaetan89 [X] (Inactive) added a comment -

        I am just not sure if this should go in 3.1 or 3.2?

        Show
        M.Gaetan89 M.Gaetan89 [X] (Inactive) added a comment - I am just not sure if this should go in 3.1 or 3.2?
        Hide
        bantu Andreas Fischer added a comment -

        Considering that not many of this type of unnecessary code is left, I'd say that 3.1 is fine.

        Show
        bantu Andreas Fischer added a comment - Considering that not many of this type of unnecessary code is left, I'd say that 3.1 is fine.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            M.Gaetan89 M.Gaetan89 [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development