Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13516

icc-profiler check should skip extensions vendor

          Details

          • Type: Bug
          • Status: Unverified Fix
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.2
          • Fix Version/s: 3.1.5-RC1
          • Component/s: Other
          • Labels:
            None

            Description

            The vendor/ directory from phpBB is skipped, however when extensions use check-image-icc-profiles.sh which have a vendor/ directory, this directory is not skipped, causing possibly broken builds if there are images with icc profiles in vendor/.

            Example: https://travis-ci.org/paul999/ajax-shoutbox-ext/jobs/47450031#L845

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              VSE Matt Friedman added a comment -

              Agreed!
              https://travis-ci.org/phpbb-extensions/collapsible-categories/jobs/57280314#L749

              Show
              VSE Matt Friedman added a comment - Agreed! https://travis-ci.org/phpbb-extensions/collapsible-categories/jobs/57280314#L749
              Hide
              Permalink
              bantu Andreas Fischer added a comment -

              Hmm. I do not like the idea of extensions depending on check-image-icc-profiles.sh at all.

              Show
              bantu Andreas Fischer added a comment - Hmm. I do not like the idea of extensions depending on check-image-icc-profiles.sh at all.

                People

                • Assignee:
                  nicofuma nicofuma
                  Reporter:
                  Paul Paul Sohier
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development