Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13505

Allow OAuth from every page

    XMLWordPrintable

    Details

      Description

      The current OAuth functionality only works on the very specific "ucp.php?mode=login" page. This is somewhat limiting, because it prevents us from including OAuth functionality in other places (like the login form on the index page).

      An extension can basically add login forms anywhere they want, without much problems, but not OAuth.

      This is because the OAuth links have a built-in redirect link:
      https://github.com/phpbb/phpbb/blob/develop/phpBB/phpbb/auth/provider/oauth/oauth.php#L334

      This means that the redirect will only function properly if the user is already on the "ucp.php?mode=login" page.

      I think we could solve this by changing to get_login_data() method to accept a redirect parameter:
      https://github.com/phpbb/phpbb/blob/develop/phpBB/phpbb/auth/provider/oauth/oauth.php#L319-L343

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            PayBas PayBas [X] (Inactive)
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: