Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13391

subsilver2 poll options must have a setting of 1 when editing a post

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.1.3-RC1
    • Component/s: Styles
    • Labels:
      None

      Description

      subsilver2 "poll options" must have a setting of 1-999 when editing a post
      /subsilver2/template/posting_poll_body.html
      <td class="row2"><input class="post" type="number" min="1" max="999" name="poll_max_options" size="3" maxlength="3" value="

      {POLL_MAX_OPTIONS}" /></td>
      should be
      <td class="row2"><input class="post" type="number" min="0" max="999" name="poll_max_options" size="3" maxlength="3" value="{POLL_MAX_OPTIONS}

      " /></td>

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment - - edited

          Please explain what the actual issue is instead of just saying how "the code" should look like. What are the implications of the issue you found? What is broken? Thanks.

          Show
          bantu Andreas Fischer added a comment - - edited Please explain what the actual issue is instead of just saying how "the code" should look like. What are the implications of the issue you found? What is broken? Thanks.
          Hide
          nickvergessen Joas Schilling added a comment -
          Show
          nickvergessen Joas Schilling added a comment - https://github.com/phpbb/phpbb/pull/1679/files was incomplete I guess...
          Hide
          Prosk8er Prosk8er added a comment -

          when you edit a post when using subsilver2 as the style if the value of "poll options" is 0 it won't let you edit the post cause of the min="1" in prosilver this is set to min="0" which doesn't have the same problem
          this post was a new post with no poll

          Show
          Prosk8er Prosk8er added a comment - when you edit a post when using subsilver2 as the style if the value of "poll options" is 0 it won't let you edit the post cause of the min="1" in prosilver this is set to min="0" which doesn't have the same problem this post was a new post with no poll

            People

            • Assignee:
              prototech prototech
              Reporter:
              Prosk8er Prosk8er
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development