Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13357

LOG_MOVED_TOPIC Language var missing

    Details

      Description

      Language var missing in [root]/language/en/acp/common.php

      'LOG_MOVED_TOPIC' => '<strong>Topic Moved</strong><br />» %s',

        Activity

        Hide
        Crizzo Crizzo added a comment -

        Hi,

        can't find where this var is used/needed. Can you explain a bit more?

        It this a very new or old entry?

        Regards

        Show
        Crizzo Crizzo added a comment - Hi, can't find where this var is used/needed. Can you explain a bit more? It this a very new or old entry? Regards
        Hide
        neufke neufke added a comment - - edited

        It is used inside the mcp logging list...

        Ow, and it is a new entry... I would have created a pull request myself but just haven't the environment setup with git.

        Show
        neufke neufke added a comment - - edited It is used inside the mcp logging list... Ow, and it is a new entry... I would have created a pull request myself but just haven't the environment setup with git.
        Hide
        Crizzo Crizzo added a comment - - edited

        I don't get it. We have already:
        'LOG_MOVE' => '<strong>Moved topic</strong><br />» from %1$s to %2$s',

        which is used in MCP-logs when a topic was moved.

        Where is your "new var" used then?

        Show
        Crizzo Crizzo added a comment - - edited I don't get it. We have already: 'LOG_MOVE' => '<strong>Moved topic</strong><br />» from %1$s to %2$s', which is used in MCP-logs when a topic was moved. Where is your "new var" used then?
        Hide
        neufke neufke added a comment -

        Again, it is used in the mcp->logging list. Don't know if it is still in use but it needs to be in place because when converting from version 3.0.12 the logging list displays the language vars, not the text.

        Show
        neufke neufke added a comment - Again, it is used in the mcp->logging list. Don't know if it is still in use but it needs to be in place because when converting from version 3.0.12 the logging list displays the language vars, not the text.
        Hide
        Crizzo Crizzo added a comment -

        But then should not
        LOG_MOVE
        and
        LOG_MOVED_TOPIC
        have the same language-string or has 3.0.12 no "%2$s" left over?

        Show
        Crizzo Crizzo added a comment - But then should not LOG_MOVE and LOG_MOVED_TOPIC have the same language-string or has 3.0.12 no "%2$s" left over?
        Hide
        neufke neufke added a comment -

        3.0.12 didn't have 2 replacements, just 1...

        Show
        neufke neufke added a comment - 3.0.12 didn't have 2 replacements, just 1...
        Hide
        Crizzo Crizzo added a comment -

        Done.

        Show
        Crizzo Crizzo added a comment - Done.
        Hide
        nickvergessen Joas Schilling added a comment -

        I can not find the string in the current version of 3.0
        So either this needs to be fixed there or the log is from a MOD you used?

        Show
        nickvergessen Joas Schilling added a comment - I can not find the string in the current version of 3.0 So either this needs to be fixed there or the log is from a MOD you used?
        Hide
        neufke neufke added a comment -

        @Joas: i was test-converting my own board from 3.0.12 to 3.1.1 when i came across this one. Can't imagine that it was from a mod but then again, won't rule it out either. I will check later where it was used and let you know. For now, just park it

        Thnx m8

        Show
        neufke neufke added a comment - @Joas: i was test-converting my own board from 3.0.12 to 3.1.1 when i came across this one. Can't imagine that it was from a mod but then again, won't rule it out either. I will check later where it was used and let you know. For now, just park it Thnx m8

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            neufke neufke
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development