Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.0.13-PL1, 3.1.1
-
Fix Version/s: 3.0.14-RC1, 3.1.4-RC1
-
Component/s: None
-
Labels:None
-
GitHub Pull Request URL:
Description
Split from https://tracker.phpbb.com/browse/PHPBB3-13298
phpBB/phpbb/feed/base.php
function get_item()
|
{
|
static $result;
|
|
|
if (!isset($result))
|
{
|
if (!$this->get_sql())
|
{
|
return false;
|
}
|
|
|
// Query database
|
$sql = $this->db->sql_build_query('SELECT', $this->sql);
|
$result = $this->db->sql_query_limit($sql, $this->num_items);
|
}
|
|
|
return $this->db->sql_fetchrow($result);
|
}
|
If we free the result when we reach the end, the next call will just query the db again. So this needs a bit investigating to make sure it does not happen.
Issue Links
- is related to
-
PHPBB3-13298
Use mysql_free_result to free result sets which were requested using mysql_query()
-
- Unverified Fix
-
Also see related develop-ascraeus PR: https://github.com/phpbb/phpbb/pull/3366