Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13228

"Code: Select all" font-size too big in Private Messages

    Details

      Description

      See attachment

        Activity

        Hide
        PayBas PayBas added a comment - - edited

        Okay so the problem is https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/styles/prosilver/theme/cp.css#L62-L64:

        #cp-main .postbody p {
            font-size: 1.1em;
        }
        

        Which is an incredibly strong selector. It would be best to replace that entirely and use a proper class instead. But that would require some testing to see if nothing breaks, because it affects every UCP/MCP module.

        The alternative would be to add !important to https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/styles/prosilver/theme/content.css#L500

        @prototech ?

        Show
        PayBas PayBas added a comment - - edited Okay so the problem is https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/styles/prosilver/theme/cp.css#L62-L64: #cp-main .postbody p { font-size: 1.1em; } Which is an incredibly strong selector. It would be best to replace that entirely and use a proper class instead. But that would require some testing to see if nothing breaks, because it affects every UCP/MCP module. The alternative would be to add !important to https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/styles/prosilver/theme/content.css#L500 @prototech ?
        Hide
        prototech prototech added a comment - - edited

        We may be able to remove it entirely. The only bbcode that makes use of the <p> tag is [code]. The only *CP templates that make use of .postbody are the following. Uses of the <p> tag within .postbody are noted next to the file.

        mcp_post.html [p.author, p.post-notice.reported, p.post-notice.unapproved, p.post-notice.deleted]
        mcp_topic.html [p.author, p.post-notice.reported, p.post-notice.unapproved, p.post-notice.deleted]
        mcp_warn_post.html
        mcp_whois.html
        posting_preview.html
        ucp_pm_history.html [p.author]
        ucp_pm_viewmessage.html [p.author]
        ucp_profile_signature.html

        From the <p> uses above, only p.author seems to be affected by the removal of the style. So, we should be able to move the font-size property under a new selector targetting p.author for *CP pages (#cp-main .postbody .author).

        Show
        prototech prototech added a comment - - edited We may be able to remove it entirely. The only bbcode that makes use of the <p> tag is [code] . The only *CP templates that make use of .postbody are the following. Uses of the <p> tag within .postbody are noted next to the file. mcp_post.html [p.author, p.post-notice.reported, p.post-notice.unapproved, p.post-notice.deleted] mcp_topic.html [p.author, p.post-notice.reported, p.post-notice.unapproved, p.post-notice.deleted] mcp_warn_post.html mcp_whois.html posting_preview.html ucp_pm_history.html [p.author] ucp_pm_viewmessage.html [p.author] ucp_profile_signature.html From the <p> uses above, only p.author seems to be affected by the removal of the style. So, we should be able to move the font-size property under a new selector targetting p.author for *CP pages (#cp-main .postbody .author).

          People

          • Assignee:
            PayBas PayBas
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development