Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13202

dead code in sessions.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC5
    • Fix Version/s: 3.1.7-RC1
    • Component/s: Sessions
    • Labels:
      None

      Description

      In phpBB/phpbb/sessions.php, we can find :

      							// If the database is not yet updated, there will be an error due to the session_forum_id
      							// @todo REMOVE for 3.0.2
      							if ($result === false)
      							{
      								unset($sql_ary['session_forum_id']);
       
      								$this->update_session($sql_ary);
      							}
      

      In addition to be very far from 3.0.2 in 3.1.x, the $result variable which originally was set by the in-line query replaced by update_session() is now meaningless and worst contains the result of the preceding query which exists in the method.

      I don't think this has great implication, but $result should either be returned by update_session or this entire code block removed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Marc Marc
                Reporter:
                dcz dcz [X] (Inactive)
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: