Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13126

More detailed output for migrations needed

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC4
    • Fix Version/s: 3.1.0
    • Component/s: Update system
    • Labels:
      None

      Description

      At the moment, on larger boards, you can have the migration sitting for 40 minutes on this:

      Installing Data: \phpbb\db\migration\data\v310\notification_options_reconvert; Time: 0.60 seconds
      Installed Data: \phpbb\db\migration\data\v310\notification_options_reconvert; Time: 0.50 seconds
      Installed Schema: \phpbb\db\migration\data\v310\plupload; Time: 0.03 seconds
      Installed Data: \phpbb\db\migration\data\v310\plupload; Time: 0.03 seconds
      Migration already effectively installed (skipped): \phpbb\db\migration\data\v310\signature_module_auth
      

      And then output

      Installed Schema: \phpbb\db\migration\data\v310\softdelete_p1; Time: 2375.15 seconds
      

      It would be helpful to know what is currently being processed. Additionally, if possible, it would be great to occasionally receive a status update ("50 out of 150 processes completed"). Perhaps simply log the time the last status was displayed, and if it was more than 5 minutes ago, display another one.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        What we can do easily, is tell the user what step we just started.
        What we can also do is hardcode the name of some migrations where we know they take a lot of time (currently all that add/remove columns from the posts table).
        But doing output mid the SQL query to report a status seems impossible to me.

        Show
        nickvergessen Joas Schilling added a comment - What we can do easily, is tell the user what step we just started. What we can also do is hardcode the name of some migrations where we know they take a lot of time (currently all that add/remove columns from the posts table). But doing output mid the SQL query to report a status seems impossible to me.
        Hide
        Marshalrusty Yuriy Rusko added a comment -

        We should also add a timer to migrations. Would be useful to know the total run time at the end.

        Show
        Marshalrusty Yuriy Rusko added a comment - We should also add a timer to migrations. Would be useful to know the total run time at the end.
        Hide
        MichaelC Michael Cullum added a comment -

        Joas: Could we not count the number of migration files and the number of rows in the migrations table at the beginning, then every x migrations show an updated count?

        Show
        MichaelC Michael Cullum added a comment - Joas: Could we not count the number of migration files and the number of rows in the migrations table at the beginning, then every x migrations show an updated count?
        Hide
        bantu Andreas Fischer added a comment -

        The general problem is that single DDL statements take a long time.

        Show
        bantu Andreas Fischer added a comment - The general problem is that single DDL statements take a long time.

          People

          • Assignee:
            nicofuma nicofuma
            Reporter:
            Marshalrusty Yuriy Rusko
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development