Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13116

Topic and post approval notifications got interchanged

    XMLWordPrintable

    Details

      Description

      https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/includes/mcp/mcp_queue.php#L746-L753

      As !$post_data['topic_posts_approved'] means unapproved topic, it seems that in this case 'notification.type.approve_topic' should be added instaed of 'notification.type.approve_post' and vise versa.

      Now, when post is getting approved, user is getting topic approval notification, and vise versa.

        Attachments

          Activity

            People

            Assignee:
            nickvergessen Joas Schilling [X] (Inactive)
            Reporter:
            rxu rxu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: