Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13070

Wrong hook name is registered for array(template, display)

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC3
    • Fix Version/s: 3.1.0-RC5
    • Component/s: None
    • Labels:

      Description

      phpbb\template\base->call_hook() launches hook
      array('phpbb\template\base', 'display')
      but /common.php registers another hook name:
      array('\phpbb\template\template', 'display')

      So template display hook (former array(template', display') in phpBB 3.0.x) is not actually launched.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        Just restore the old name. New stuff should use event, old stuff should still work with the old name

        Show
        nickvergessen Joas Schilling added a comment - Just restore the old name. New stuff should use event, old stuff should still work with the old name
        Hide
        prototech prototech added a comment -

        common.php also needs editing - the hook is never executed due to this.
        https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/common.php#L107

        Show
        prototech prototech added a comment - common.php also needs editing - the hook is never executed due to this. https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/common.php#L107

          People

          • Assignee:
            Marc Marc
            Reporter:
            Dionisiy Dionisiy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development