Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13052

Remove additional parameters from check_form_key()

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC3
    • Fix Version/s: 3.1.0-RC4
    • Component/s: None
    • Labels:
      None

      Description

      The order of the parameters implies a wrong behaviour and the additional parameters are only used once.
      So in order to avoid the confusion, we should just remove them and adjust the one call with the parameters accordingly.

        Activity

        Hide
        VSE Matt Friedman added a comment - - edited

        Umm. Can you bring back the timespan parameter. I used that. Just because the core never used it doesn't mean MODs/extensions didn't use it.

        For example, on my forum, I had a specific need for it, as requested by users, where I had a long custom form that the users could fill out to submit articles to the site. There were complaints that they spent so much time working on their content that the form would expire by the time they tried to submit it.

        So I used the check_form_key('form_name', -1) technique to disable any time restrictions on that form.

        Show
        VSE Matt Friedman added a comment - - edited Umm. Can you bring back the timespan parameter. I used that. Just because the core never used it doesn't mean MODs/extensions didn't use it. For example, on my forum, I had a specific need for it, as requested by users, where I had a long custom form that the users could fill out to submit articles to the site. There were complaints that they spent so much time working on their content that the form would expire by the time they tried to submit it. So I used the check_form_key('form_name', -1) technique to disable any time restrictions on that form.
        Hide
        nickvergessen Joas Schilling added a comment -

        sure we can

        Show
        nickvergessen Joas Schilling added a comment - sure we can
        Hide
        VSE Matt Friedman added a comment -

        <3

        Show
        VSE Matt Friedman added a comment - <3

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development