Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC3
    • Fix Version/s: 3.1.0-RC4
    • Component/s: Styles
    • Labels:
      None

      Description

      Hello,

      First of all, I would like to make it clear that this is not very important and I agree that meta tags are not very useful, but they have some cosmetic yet real usages too.

      Anyway, we can find this in both provsilver and subsilver's overall_header.html :

      <meta name="keywords" content="" />
      <meta name="description" content="" />
      

      This, is addition to being useless, makes it impossible for extension to set up these meta tags as wished using the overall_header_head_append event.

      I don't think phpBB should make such restriction, so I suggest to remove these too lines or at least to make them conditional with a template variable.

      I originally posted here : https://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=45907

      But I though it may finally be more appropriate to fill a bug report.

      Regards,

      dcz

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        I see the point, and I guess we should just remove them, so extensions can do that.

        Show
        nickvergessen Joas Schilling added a comment - I see the point, and I guess we should just remove them, so extensions can do that.
        Hide
        bantu Andreas Fischer added a comment -

        I agree. dcz, want to send a pull request for this?

        Show
        bantu Andreas Fischer added a comment - I agree. dcz, want to send a pull request for this?
        Hide
        dcz dcz [X] (Inactive) added a comment -

        Here is the pull request https://github.com/phpbb/phpbb/pull/2923

        ++

        Show
        dcz dcz [X] (Inactive) added a comment - Here is the pull request https://github.com/phpbb/phpbb/pull/2923 ++

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            dcz dcz [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development