Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13019

Don't display "Soft delete reason" dialog when moderator cannot soft-delete

          Details

          • Type: Bug
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.1.0-RC3
          • Fix Version/s: 3.1.0-RC4
          • Component/s: JavaScript / AJAX, Styles
          • Labels:
            None

            Description

            If an admin/moderator doesn't have permissions to soft-delete topics, it shouldn't display the "Soft delete reason:" input box.

            This will cause confusion, because they might be under the impression that they are soft-deleting a topic, when in fact they are permanently deleting it.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              nicofuma nicofuma added a comment -

              in fact the title is wrong because it's not a "Soft delete reason" but a "(Soft) delete reason" (now the reason is always used and stored in the logs)

              Show
              nicofuma nicofuma added a comment - in fact the title is wrong because it's not a "Soft delete reason" but a "(Soft) delete reason" (now the reason is always used and stored in the logs)
              Hide
              Permalink
              Josh Josh Simpson added a comment -

              Replicated in 3.1.0 RC4

              User with hard delete permission and no soft delete permission is still shown "Soft delete reason"

              Entering a reason and acknowledging HARD deletes the post, but also the Reason appears to not being stored correctly in the Moderator Logs.

              "for the following reason
              » (empty value)"

              Show
              Josh Josh Simpson added a comment - Replicated in 3.1.0 RC4 User with hard delete permission and no soft delete permission is still shown "Soft delete reason" Entering a reason and acknowledging HARD deletes the post, but also the Reason appears to not being stored correctly in the Moderator Logs. "for the following reason » (empty value)"
              Hide
              Permalink
              PayBas PayBas [X] (Inactive) added a comment -

              Additionally. When deleting shadow topics, you can also enter a "reason", but it's never used.

              To be honest, I was almost scared I had hit the wrong button (delete the topic itself, instead of the shadow).

              Show
              PayBas PayBas [X] (Inactive) added a comment - Additionally. When deleting shadow topics, you can also enter a "reason", but it's never used. To be honest, I was almost scared I had hit the wrong button (delete the topic itself, instead of the shadow).
              Hide
              Permalink
              nickvergessen Joas Schilling added a comment -

              Deleting a shadow topic should not show the fields. can you open a new ticket?

              Show
              nickvergessen Joas Schilling added a comment - Deleting a shadow topic should not show the fields. can you open a new ticket?

                People

                • Assignee:
                  prototech prototech
                  Reporter:
                  PayBas PayBas [X] (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development