Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12955

"Jump to" button text alignment

    XMLWordPrintable

Details

    Description

      While working on the Hebrew translation for the new 3.1 version, I noticed that the "Jump to" button in the View Forum and View Topic files is not aligned correctly.
      This issue is probably common to all the RTL-s translations.
      Attached are screenshots of the button in the correct alignment in English, and the wrong alignment before fix, in Hebrew.
      Attached is also the screenshot of the correct alignment after my fix.

      The problematic CSS definition is .dropdown-select.
      After fixing this issue, I noticed a mismatch between the default English definition in buttons.css file, that sets padding-right to 24px, and the RTL definition in bidi.css file, that sets padding-left to a different size of 26px.

      This issue has been fixed too in my commit.

      Attachments

        1. JumpTo_After.png
          JumpTo_After.png
          0.9 kB
        2. JumpTo_After_PaddingLeft24.png
          JumpTo_After_PaddingLeft24.png
          0.9 kB
        3. JumpTo_Before.png
          JumpTo_Before.png
          0.9 kB
        4. JumpTo_English.png
          JumpTo_English.png
          1 kB

        Issue Links

          Activity

            People

              prototech prototech [X] (Inactive)
              Chisor Chisor [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: