Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12952

Display HTTP Output along with Status code in case assertion fails in functional tests

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC2
    • Fix Version/s: 3.1.6-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Activity

      Hide
      bantu Andreas Fischer added a comment -

      Test execution stops as soon as an assertion fails, so the status code complaint will not be visible after this patch.

      Show
      bantu Andreas Fischer added a comment - Test execution stops as soon as an assertion fails, so the status code complaint will not be visible after this patch.
      Hide
      Marc Marc added a comment -

      Well the question is really if it's more important to know if the status code is unexpected or that there is something before the start of a document in form of an error message. If there are no errors and the status code is still wrong, the status code message will still show.

      I do think that it's more important to see the actual error message instead of just the status code assertion. We could of course also output the content in addition to the status code message if you like that more?

      Show
      Marc Marc added a comment - Well the question is really if it's more important to know if the status code is unexpected or that there is something before the start of a document in form of an error message. If there are no errors and the status code is still wrong, the status code message will still show. I do think that it's more important to see the actual error message instead of just the status code assertion. We could of course also output the content in addition to the status code message if you like that more?
      Hide
      bantu Andreas Fischer added a comment - - edited

      I agree with you. I just wanted to note that the ticket subject is not exactly true/implemented now. No major issue, though.

      Show
      bantu Andreas Fischer added a comment - - edited I agree with you. I just wanted to note that the ticket subject is not exactly true/implemented now. No major issue, though.

        People

        • Assignee:
          Marc Marc
          Reporter:
          dhruv.goel92 Dhruv Goel
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development