Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12892

S_NUM_ROWS does not scale

          Details

          • Type: Improvement
          • Status: Unverified Fix
          • Priority: Blocker
          • Resolution: Fixed
          • Affects Version/s: 3.1.0-RC2
          • Fix Version/s: 3.1.0-RC3
          • Component/s: Template Engine
          • Labels:
            None

            Description

            The S_NUM_ROWS for template loops does not scale very well.
            The creation/adjustment when adding a row requires n - 1 loops over a reference.
            So in the end it's n! (n factorial) which is really bad.

            This should be avoidable.

              Issue Links

              is related to

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-12891 Long page generation time when banlist is long

              • Major - Major loss of function.
              • Unverified Fix

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-12232 MCP Banning: Max execution time exceeded

              • Major - Major loss of function.
              • Closed

                Activity

                Hide
                Permalink
                nickvergessen Joas Schilling added a comment -

                Oliver Schramm suggests to set S_NUM_ROWS, S_FIRST_ROW and S_LAST_ROW on display() instead of each loop, I guess that would be one easy way to do it.

                Show
                nickvergessen Joas Schilling added a comment - Oliver Schramm suggests to set S_NUM_ROWS, S_FIRST_ROW and S_LAST_ROW on display() instead of each loop, I guess that would be one easy way to do it.

                  People

                  • Assignee:
                    nickvergessen Joas Schilling
                    Reporter:
                    nickvergessen Joas Schilling
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development