Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12864

Have an EVENT tag after STYLESHEETS in overall_header

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev, 3.1.0-RC2
    • Fix Version/s: 3.1.0-RC3
    • Component/s: Events, Styles
    • Labels:
      None

      Description

      In overall_header.html, an EVENT should be available after the STYLESHEETS tag.

      This would allow style tags to be used after the included CSS files that can over-write styling from the linked CSS files if needed. It can also allow stuff to truly be inserted immediately before the closing head tag.

      But we still need the EVENT before STYLESHEETS so extensions can use INCLUDECSS.

      Perhaps have a new prepend event and some re-arranging:

      <!-- EVENT overall_header_head_prepend -->
       
      {$STYLESHEETS}
       
      <!-- EVENT overall_header_head_append -->
      

        Activity

        Hide
        PayBas PayBas [X] (Inactive) added a comment -

        I agree, but I think "prepend" right before {$STYLESHEETS} would be somewhat misleading.

        <!-- EVENT overall_header_stylesheets_after --> would accomplish the same thing, without breaking anything.

        Show
        PayBas PayBas [X] (Inactive) added a comment - I agree, but I think "prepend" right before {$STYLESHEETS} would be somewhat misleading. <!-- EVENT overall_header_stylesheets_after --> would accomplish the same thing, without breaking anything.
        Hide
        nickvergessen Joas Schilling added a comment -

        Renaming overall_header_head_append or moving it (so it breaks CSS loading) is not an option.

        Show
        nickvergessen Joas Schilling added a comment - Renaming overall_header_head_append or moving it (so it breaks CSS loading) is not an option.

          People

          • Assignee:
            Marc Marc
            Reporter:
            VSE Matt Friedman
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development