Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12857

Add template events overall_header_breadcrumbs_before/after

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC2
    • Fix Version/s: 3.1.0-RC3
    • Component/s: Styles
    • Labels:
      None

      Description

      All template events in the navlinks (breadcrumbs) list are currently inside <li> elements.

      This kinda limits the possibilities. I think it's a good idea to have some events outside the <li>

        Activity

        Show
        wintstar wintstar added a comment - The position does not make sense. Please look here https://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45371 https://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45373
        Hide
        PayBas PayBas [X] (Inactive) added a comment - - edited

        What you want is <!-- EVENT overall_header_breadcrumb_prepend --> (and footer)

        I'll add it too

        edit: to clarify. This ticket was meant to let extensions add content to the <ul>. That way they could add their own <li> items and have them float:right or something. Like when they want to add small icons next to the responsive-search icon, etc.

        Show
        PayBas PayBas [X] (Inactive) added a comment - - edited What you want is <!-- EVENT overall_header_breadcrumb_prepend --> (and footer) I'll add it too edit: to clarify. This ticket was meant to let extensions add content to the <ul>. That way they could add their own <li> items and have them float:right or something. Like when they want to add small icons next to the responsive-search icon, etc.
        Hide
        wintstar wintstar added a comment -

        Yes all right PyBas. But if the forum embedded (iframe or similar) then it looks from the following:

        on the first position = ACP function Homepage-URL
        secon position = <!-- EVENT overall_footer_breadcrumb_append -->
        <!-- EVENT overall_header_breadcrumb_append -->

        Show
        wintstar wintstar added a comment - Yes all right PyBas. But if the forum embedded (iframe or similar) then it looks from the following: on the first position = ACP function Homepage-URL secon position = <!-- EVENT overall_footer_breadcrumb_append --> <!-- EVENT overall_header_breadcrumb_append -->
        Hide
        PayBas PayBas [X] (Inactive) added a comment -

        That's why I just added <!-- EVENT overall_header_breadcrumb_prepend --> AFTER the site-home link.

        It will be possible to do this:

        < ul >
        EVENT overall_header_breadcrumbs_before
           < li breadcrumbs>
              < site home > (ACP option)
              EVENT overall_header_breadcrumb_prepend
              < board index >
              < crumbs > (with prepend/append events)
              EVENT overall_header_breadcrumb_append
           < /li>
        EVENT overall_header_breadcrumbs_after
        < /ul >

        That should be enough, right?

        Show
        PayBas PayBas [X] (Inactive) added a comment - That's why I just added <!-- EVENT overall_header_breadcrumb_prepend --> AFTER the site-home link. It will be possible to do this: < ul > EVENT overall_header_breadcrumbs_before < li breadcrumbs> < site home > (ACP option) EVENT overall_header_breadcrumb_prepend < board index > < crumbs > (with prepend/append events) EVENT overall_header_breadcrumb_append < /li> EVENT overall_header_breadcrumbs_after < /ul > That should be enough, right?
        Hide
        wintstar wintstar added a comment -

        yes so it is perfectly

        Show
        wintstar wintstar added a comment - yes so it is perfectly

          People

          • Assignee:
            Marc Marc
            Reporter:
            PayBas PayBas [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development