Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12853

Problems with ACP/MCP links in mobile design with other translations

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC2
    • Fix Version/s: 3.1.0-RC3
    • Component/s: Language pack, Styles
    • Labels:
      None

      Description

      Currently we use ACP and MCP as link texts for the links in the header.
      However these shortcuts do not work for all languages.
      So e.g. german still uses the verbs from before the header change.
      However they are too long and do not get hidden by responsive design at the moment.

      We should change the data-skip-responsive into data-last-responsive so If it is a problem, the links still get wrapped into the menu.

        Activity

        Hide
        Dr.Death Dr.Death added a comment -

        Maybe it is enough to put only the ACP Link into the quick links menu:

        <!-- IF U_ACP --><li class="small-icon icon-acp" data-last-responsive="true"><a href="{U_ACP}" title="{L_ACP}" role="menuitem">{L_ACP_SHORT}</a></li><!-- ENDIF -->

        because a Moderator is using the quick links more often than an Administrator....

        Show
        Dr.Death Dr.Death added a comment - Maybe it is enough to put only the ACP Link into the quick links menu: <!-- IF U_ACP --><li class="small-icon icon-acp" data-last-responsive="true"><a href="{U_ACP}" title="{L_ACP}" role="menuitem">{L_ACP_SHORT}</a></li><!-- ENDIF --> because a Moderator is using the quick links more often than an Administrator....
        Hide
        nickvergessen Joas Schilling added a comment -

        yeah, thats what our thoughts on IRC were aswell.

        Show
        nickvergessen Joas Schilling added a comment - yeah, thats what our thoughts on IRC were aswell.
        Hide
        PayBas PayBas [X] (Inactive) added a comment - - edited

        One small problem with this is that we recently moved the ACP/MCP to the end of the list (in order to prevent the links from jumping when MCP is not available on certain pages). See: https://tracker.phpbb.com/browse/PHPBB3-12824

        So when we change ACP to responsive-last, it will be handled like other links, and placed in the dropdown in the same order. The result will be that it will be placed between FAQ and the other quick-links.

        I don't suppose we want this.

        If this is indeed unacceptable, we basically have 2 options. [1] Move the ACP back to the front of the list, or [2] use JS to detect the ACP and move it to the top of the list.

        Show
        PayBas PayBas [X] (Inactive) added a comment - - edited One small problem with this is that we recently moved the ACP/MCP to the end of the list (in order to prevent the links from jumping when MCP is not available on certain pages). See: https://tracker.phpbb.com/browse/PHPBB3-12824 So when we change ACP to responsive-last, it will be handled like other links, and placed in the dropdown in the same order. The result will be that it will be placed between FAQ and the other quick-links. I don't suppose we want this. If this is indeed unacceptable, we basically have 2 options. [1] Move the ACP back to the front of the list, or [2] use JS to detect the ACP and move it to the top of the list.
        Hide
        Dr.Death Dr.Death added a comment - - edited

        I would prefer then [2] and move the hidden ACP Link to the top of the Quick Link Menu.

        Show
        Dr.Death Dr.Death added a comment - - edited I would prefer then [2] and move the hidden ACP Link to the top of the Quick Link Menu.
        Hide
        rxu Ruslan Uzdenov added a comment -

        The problem still persists with long usernames and/or long translated entry of MCP.

        Show
        rxu Ruslan Uzdenov added a comment - The problem still persists with long usernames and/or long translated entry of MCP.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development