Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.1.0-RC2
-
Fix Version/s: 3.1.0-RC4
-
Component/s: None
-
Labels:None
-
GitHub Pull Request URL:
Description
If you do something like :
append_sid($phpbb_root_path . "script.$php_ext", "do=something&continue");
You get a notice :
[phpBB Debug] PHP Notice: in file [ROOT]/phpbb/path_helper.php on line 356: Undefined offset: 1
Because the code assumes that a value is set for the $_REQUEST's 'continue' key :
list($key, $value) = explode('=', $argument, 2);
I don't think phpbb should enforce such restrictions on urls. Fix could be to wrap this with a strpos test :
if (strpos($argument, '=') !== false) { list($key, $value) = explode('=', $argument, 2); } else { $key = $argument; $value = null; }